rubydragon/metagraphoptimization.jl
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Seed Randomness, Fix tests (#8)
All checks were successful
MetagraphOptimization_CI / docs (push) Successful in 7m34s
Details
MetagraphOptimization_CI / test (push) Successful in 20m49s
Details

Browse Source 
Seeded randomness in all places, however, multithreaded randomness still exists.

Disabled some tests that are failing, will add issues and fix later. These are related to (likely) precision problems in the ABC model, which is not priority, and the Node Fusion, which will be fundamentally reworked anyways.

Co-authored-by: Anton Reinhard <anton.reinhard@proton.me>
Reviewed-on: #8
This commit is contained in:
rubydragon
2024-05-08 18:04:48 +02:00
parent 7d7782f97f
commit 38e7ff3b90
8 changed files with 39 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/known_graphs.jl
View File

@ -1,6 +1,8 @@
using MetagraphOptimization
using Random
RNG = Random.MersenneTwister(321)
function test_known_graph(name::String, n, fusion_test = true)
@testset "Test $name Graph ($n)" begin
graph = parse_dag(joinpath(@__DIR__, "..", "input", "$name.txt"), ABCModel())
@ -9,7 +11,7 @@ function test_known_graph(name::String, n, fusion_test = true)
if (fusion_test)
test_node_fusion(graph)
end
test_random_walk(graph, n)
test_random_walk(RNG, graph, n)
end
end
@ -43,7 +45,7 @@ function test_node_fusion(g::DAG)
end
end
function test_random_walk(g::DAG, n::Int64)
function test_random_walk(RNG, g::DAG, n::Int64)
@testset "Test Random Walk ($n)" begin
# the purpose here is to do "random" operations and reverse them again and validate that the graph stays the same and doesn't diverge
reset_graph!(g)
@ -54,18 +56,18 @@ function test_random_walk(g::DAG, n::Int64)
for i in 1:n
# choose push or pop
if rand(Bool)
if rand(RNG, Bool)
# push
opt = get_operations(g)
# choose one of fuse/split/reduce
option = rand(1:3)
option = rand(RNG, 1:3)
if option == 1 && !isempty(opt.nodeFusions)
push_operation!(g, rand(collect(opt.nodeFusions)))
push_operation!(g, rand(RNG, collect(opt.nodeFusions)))
elseif option == 2 && !isempty(opt.nodeReductions)
push_operation!(g, rand(collect(opt.nodeReductions)))
push_operation!(g, rand(RNG, collect(opt.nodeReductions)))
elseif option == 3 && !isempty(opt.nodeSplits)
push_operation!(g, rand(collect(opt.nodeSplits)))
push_operation!(g, rand(RNG, collect(opt.nodeSplits)))
else
i = i - 1
end
@ -87,8 +89,6 @@ function test_random_walk(g::DAG, n::Int64)
end
end
Random.seed!(0)
test_known_graph("AB->AB", 10000)
test_known_graph("AB->ABBB", 10000)
test_known_graph("AB->ABBBBB", 1000, false)